[wip]fix: mint selection onboarding refinement#229
Draft
swedishfrenchpress wants to merge 13 commits intomainfrom
Draft
[wip]fix: mint selection onboarding refinement#229swedishfrenchpress wants to merge 13 commits intomainfrom
swedishfrenchpress wants to merge 13 commits intomainfrom
Conversation
…dits, default mint copy update.
…iable hit testing, adjust row padding to maintain visual alignment
…the default mint.
swedishfrenchpress
changed the title
Remove TermsBottomSheet and revert welcome screen styling (TOS dialog, terms text style, accept button elevation) back to master so splash screen updates can be done on a separate branch. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… system Use Widget.Button.Primary.Green and Widget.Button.Secondary.Outlined styles from the withdraw branch for consistency. Replace the ad-hoc bottom sheet scan row with a proper outlined MaterialButton. Fix purple button color by adding colorPrimary to the bottom sheet theme. Add text color state list so disabled buttons show readable gray text. Update hint copy to "Enter mint URL". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace the plain Default Mint header + row with a hero card matching the Auto-Withdraw design — gradient background, lightning bolt watermark, and elevated typography. Remove chevrons from wallet setup options. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove 5 tests that referenced view IDs from an abandoned drag-and-drop UI iteration (add_different_mint_card, mints_subtitle, mints_list_container, mints_count_text). These IDs no longer exist in activity_onboarding.xml. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
swedishfrenchpress
changed the title
swedishfrenchpress
changed the title
swedishfrenchpress
changed the title
…green Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
swedishfrenchpress
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Onboarding and mint selection redesign
Summary
Redesigned the mint selection onboarding screen to introduce a clear two-section layout (Default Mint + Popular Mints), improved bottom sheet interactions.
Demo
Sunmi POS:
sunmi-v2-mint-selection-full.mp4
Pixel 6a:
pixel-6a-mint-selection.mp4
Changes
Mint selection screen — new structure
The mint selection screen now has two distinct sections:
On first launch, the app randomly assigns one of the popular mints as the default to avoid centralization risk around any single mint.
Manually added mints become the default
When a user adds a new mint manually — either by typing a URL or scanning a QR code — that mint is automatically set as the default. The previous default moves to the popular mints list. The assumption is that if a user goes through the effort of adding a mint themselves, they want it as their primary.
Star tap target expanded
Star
ImageViewincreased from 24×24dp to 44×44dp with 10dp padding (visual icon stays 24dp). RowpaddingStartreduced from 16dp to 6dp to maintain visual alignment.marginEndremoved since the star's right padding now provides spacing. This fixes accidental checkbox toggles when trying to tap the star.Add a Mint bottom sheet
Known issue: Popular Mints clipping on small screens (Sunmi)
sunmi-v2-mint-selection-issue.mp4
On the Sunmi POS and similarly small-screen devices, if there are 3+ popular mints, the last mint in the list is not visible without scrolling. Unlike slightly larger screens where a partial row peeks out and hints at more content, on the Sunmi the third mint is completely hidden.
Solutions considered:
Decision: Keeping as-is for now. The Sunmi is a niche merchant device with known screen constraints. The list is scrollable and all mints are reachable — the discoverability gap is a tradeoff we're accepting for now rather than introducing layout complexity that affects all devices. Will revisit if merchant feedback indicates this is causing real friction.